Look at stdout and stderr of k0s etcd member-list separately #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be a problem to do it on all versions? It's also possible to get separate streams with something like: var stdoutbuf, stderrbuf bytes.Buffer
cmd, err := h.ExecStreams("command", nil, &stdoutbuf, &stderrbuf, exec.Sudo(h)) // first nil is stdin
if err != nil {
return fmt.Errorf("failed to create command: %w", err)
}
if err := cmd.Wait(); err != nil {
return fmt.Errorf("command failed: %w", err)
}
// parse stdout, maybe log stderr |
Oh, that was the method I was looking for 😅 |
|
I'm currently experiencing it: |
4 tasks
4 tasks
Sometimes, random log statements may appear on stderr, which can break
the parsing. Try to parse stdout first, then fallback to stderr. Error
out if none of both was a JSON document.
An example log line on stderr looks like this:
W0917 07:11:23.255691 3096 logging.go:55] [core] [Channel k0sproject#1 SubChannel k0sproject#2]grpc: addrConn.createTransport failed to connect to {Addr: "127.0.0.1:2379", ServerName: "127.0.0.1:2379", }. Err: connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:2379: operation was canceled"
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
etcd-member-log-stderr
branch
from
0185b51 to
e620285
Compare
twz123
changed the title
kke
reviewed
Oct 14, 2025
| result map[string]any | ||
| errs []error | ||
| ) | ||
| for _, output := range [][]byte{stdout.Bytes(), stderr.Bytes()} { |
There was a problem hiding this comment.
Maybe a bit overkill to try parsing stderr for json, but sure, why not
There was a problem hiding this comment.
This is for the old k0s versions which write the JSON to stderr.
kke
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, random log statements may appear on stderr, which can break the parsing. Try to parse stdout first, then fallback to stderr. Error out if none of both was a JSON document.
An example log line on stderr looks like this: